Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return type Document for parse_file() #836

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bact
Copy link

@bact bact commented Nov 26, 2024

Add a return type to spdx.parser.parse_anything.parse_file function.

Since all parse_from_file() functions from

  • rdf_parser
  • tagvalue_parser
  • json_parser
  • xml_parser and
  • yaml_parser

that parse_file() is calling, are returning Document,
it should be safe to declare that parse_file() return Document as well.

This will assist type checking.

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants