Add return type Document for parse_file() #836
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a return type to
spdx.parser.parse_anything.parse_file
function.Since all
parse_from_file()
functions fromrdf_parser
tagvalue_parser
json_parser
xml_parser
andyaml_parser
that
parse_file()
is calling, are returningDocument
,it should be safe to declare that
parse_file()
returnDocument
as well.This will assist type checking.