BugFix : Removing case sensitivity of licenseIds #784
Conversation
Signed-off-by: Puneeth <[email protected]>
| @@ -40,7 +40,7 @@ def validate_license_expression( | |||
| ) | |||
|
|
|||
| validation_messages = [] | |||
| license_ref_ids: List[str] = [license_ref.license_id for license_ref in document.extracted_licensing_info] | |||
| license_ref_ids: List[str] = [license_ref.license_id.lower() for license_ref in document.extracted_licensing_info] | |||
There was a problem hiding this comment.
going to .lower() feels wrong, as the upper case is the default for most licenses?
There was a problem hiding this comment.
Should I take any other approach to make licenseIds case insensitive.(we have couple of other methods other than .lower())
Or keeping them case sensitive is just fine:(
Well, what are your thoughts?
There was a problem hiding this comment.
Sorry, I'm new to licenses and stuff.
It would be great to have your opinion
There was a problem hiding this comment.
I think uppercase would be more consistent
|
Can you please also add tests to show and test the new behaviour? |
|
As this is also relevant for matching and relating licenseRefs, I assume that this also needs changes beyond the validation layer. |
Sure....but it can take a while I'll add them by this weekend |
|
@puneeth072003 , do you plan to continue on that topic? I think this is a helpful and important feature, but a consistent and complete implementation is necessary |
|
@maxhbr sure I'd like to continue |
|
Hi @puneeth072003, are you still working on this? Otherwise I can take over from you if you like. |
|
@armintaenzertng yep sure! I'm lil preoccupied at the moment you can take over this one |
|
Hi, Is there any update on this one? Was hoping to get a fix for the same issue: #810 |
This PR fixes the issue #165 from
ntia-conformance-checkerrepo.