Check license headers with reuse #704
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fholger
commented
Jun 23, 2023
| @@ -1,3 +1,7 @@ | |||
| # SPDX-FileCopyrightText: 2023 spdx contributors | |||
There was a problem hiding this comment.
This file looks like it may have been copied from dependabot (due to the comments below), so I am not sure if this license and copyright is correct.
fholger
commented
Jun 23, 2023
| Copyright: 2023 spdx contributors | ||
| License: Apache-2.0 | ||
|
|
||
| Files: assets/* |
There was a problem hiding this comment.
The assets folder currently contains a single png image, which is an example output of the graph generation. What license should this have?
fholger
commented
Jun 23, 2023
| Copyright: 2023 spdx contributors | ||
| License: Apache-2.0 | ||
|
|
||
| Files: *.md |
There was a problem hiding this comment.
Should documentation have a separate license, or is sticking to Apache ok?
fholger
commented
Jun 23, 2023
| Copyright: 2023 spdx contributors | ||
| License: Apache-2.0 | ||
|
|
||
| Files: |
There was a problem hiding this comment.
These files are generated/derived from spdx-3-model, which is covered by the Community Specification License.
fholger
force-pushed
the
check_license_headers_with_reuse
branch
from
afd0aef to
38fabb7
Compare
Signed-off-by: Holger Frydrych <[email protected]>
…not feasible (e.g. test data, generated files, documentation and images) Signed-off-by: Holger Frydrych <[email protected]>
…expects it for full reuse compliance Signed-off-by: Holger Frydrych <[email protected]>
Signed-off-by: Holger Frydrych <[email protected]>
Signed-off-by: Holger Frydrych <[email protected]>
fholger
force-pushed
the
check_license_headers_with_reuse
branch
from
38fabb7 to
a18830d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #703. Closes #689.
This PR adds missing license and copyright information for all files (either by adding a license header or bulk-marking the files in
.reuse/dep5where license headers are not possible/undesired) and attempts to achieve full compliance with the reuse-tool. Reuse is now also called in the GitHub actions pipeline to ensure compliance going forward.I am marking this PR as a draft because I am not entirely sure about the correct license for some of these files, but I hope that this PR can serve as a discussion on what the correct choices should be.