Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug standalone binary build #2348

Closed
wants to merge 3 commits into from

Conversation

rosteen
Copy link
Collaborator

@rosteen rosteen commented Aug 8, 2023

Does what it says on the tin. This build was passing in #1960, trying to figure out what changed. Note that I temporarily enabled the stand alone build for PRs so I can see test it here, this will be dropped before merge.

@rosteen rosteen added the no-changelog-entry-needed changelog bot directive label Aug 8, 2023
@rosteen rosteen added this to the 3.6.2 milestone Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 75.86% and project coverage change: +0.02% 🎉

Comparison is base (eed8420) 90.63% compared to head (8698843) 90.66%.
Report is 1 commits behind head on main.

❗ Current head 8698843 differs from pull request most recent head e21dd28. Consider uploading reports for the commit e21dd28 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2348      +/-   ##
==========================================
+ Coverage   90.63%   90.66%   +0.02%     
==========================================
  Files         152      152              
  Lines       17407    17422      +15     
==========================================
+ Hits        15777    15795      +18     
+ Misses       1630     1627       -3     
Files Changed Coverage Δ
...configs/default/plugins/export_plot/export_plot.py 59.44% <69.56%> (+5.70%) ⬆️
...configs/cubeviz/plugins/tests/test_export_plots.py 77.77% <100.00%> (+2.02%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosteen rosteen closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant