feat: TypedAxios 모듈 생성 #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 프리뷰 배포 확인하기 🚀 |
NamJwong
reviewed
Apr 28, 2023
Comment on lines
+35
to
+38
| const zodError = String(res.error).slice(0, 1000) + '\n...'; | ||
| const message = `서버 타입 검증에 실패했습니다. (${axiosConfig.method} ${axiosConfig.url})\n${zodError}`; | ||
| console.error(zodError); | ||
| throw new Error(message); |
| }; | ||
| } | ||
|
|
||
| export type GetResponseType<T> = T extends Endpoint<infer R, never> ? R : never; |
There was a problem hiding this comment.
TS 고수님 ,, 혹시 <infer R, never>에서 왜 never로 한 건지 알려주실 수 있나요? 🥺
There was a problem hiding this comment.
R 을 infer 해 오는것만 중요하고, 두번째 제너릭 인자는 필요가 없기 때문에 never를 줬어요! (사실 unknown[] 로 해도 작동해요.)
NamJwong
reviewed
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤫 쉿, 나한테만 말해줘요. 이슈넘버
🧐 어떤 것을 변경했어요~?
서버의 타입을 한번 더 검증하는
typedAxios.ts모듈을 추가했어요.createEndpoint를 통해서 선언적으로 서버에서 오는 값의 타입을 zod로 검증할 수 있어요.현재는 예시를 위해서 일부 endpoint 에만 새로운 변경 사항을 적용했어요. 차차 다른 endpoint 들에도 적용할 예정이에요.
🤔 그렇다면, 어떻게 구현했어요~?
제너릭을 적절하게 사용해서, serverResponse 에 들어간 Zod Schema 를 넣으면 타입 추론이 되도록 했어요.
.request함수 호출시 axios 호출 후 zod 타입 검증까지 진행해요.❤️🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.
📸 스크린샷, 없으면 이것 참,, 섭섭한데요?