Integrate image viewer in Star sample #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
changed the title
saket
approved these changes
Jun 18, 2023
There was a problem hiding this comment.
I'm sad that the image in full screen viewer does not display immediately. There's a visible delay of a frame or two. Could that be because of saket/telephoto#8?
|
That's possible yeah, I haven't investigated it too much. This is using Coil's memory cache key setup so it should be instant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new image viewer in the STAR sample app. This gives us a good testing ground for shared element transitions (#50) and also cleans up a bit of the edge to edge behavior in the app.
output2.mp4
Resolves #129