Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample - Add a full screen photo viewer from detail #129

Closed
ZacSweers opened this issue Sep 21, 2022 · 2 comments · Fixed by #669
Closed

Sample - Add a full screen photo viewer from detail #129

ZacSweers opened this issue Sep 21, 2022 · 2 comments · Fixed by #669
Labels
enhancement New feature or request samples Anything relating to sample projects

Comments

@ZacSweers
Copy link
Collaborator

ZacSweers commented Sep 21, 2022 •
edited
Loading

Could be a good demo for a transition with a hero element (photo animates to full screen)

Related: #50
@ZacSweers ZacSweers added enhancement New feature or request samples Anything relating to sample projects labels Sep 21, 2022
@ZacSweers ZacSweers mentioned this issue Sep 21, 2022
Closed
@ZacSweers
Copy link
Collaborator Author

Bonus if we can also do a hero transition from pet list -> detail page while tinkering with this

@ZacSweers
Copy link
Collaborator Author

Would be a good demo with Telephoto: https://github.com/saket/telephoto/

@ZacSweers ZacSweers mentioned this issue Jun 7, 2023
Merged
ZacSweers added a commit that referenced this issue Jun 24, 2023
@ZacSweers
Integrate image viewer in Star sample (#669)
a450139 
This adds a new image viewer in the STAR sample app. This gives us a
good testing ground for shared element transitions (#50) and also cleans
up a bit of the edge to edge behavior in the app.


https://github.com/slackhq/circuit/assets/1361086/5a343f95-395a-4c90-b4ec-de226f124387

Resolves #129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request samples Anything relating to sample projects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrate image viewer in Star sample slackhq/circuit
1 participant
@ZacSweers