Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

place the class into a psr-0 setup so that other modules can #1

Open
wants to merge 1 commit into
base: 7.x-1.x
Choose a base branch
from

Conversation

alnutile
Copy link

Use psr-0 to extend or include the class

Using

use GithubApi\DrupalGithubApiHttpClientCacheDrupalNativeCache;

and / or

class SomeOtherClass extends DrupalGithubApiHttpClientCacheDrupalNativeCache

This way there is a more constant coding standard and not using *.info to include the file.

@skwashd
Copy link
Owner

skwashd commented Sep 2, 2014

@alnutile I'm open to do this, but the patch doesn't apply cleanly. The patch also loses the history of the class, you need to do a git mv. Please re-roll it.

@alnutile
Copy link
Author

alnutile commented Sep 2, 2014

Cool will trying do it 2 night.

-----Original Message-----
From: "Dave Hall" [email protected]
Sent: ‎9/‎2/‎2014 5:43 AM
To: "skwashd/github_api" [email protected]
Cc: "Alfred Nutile" [email protected]
Subject: Re: [github_api] place the class into a psr-0 setup so that othermodules can (#1)

@alnutile I'm open to do this, but the patch doesn't apply cleanly. The patch also loses the history of the class, you need to do a git mv. Please re-roll it.

Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants