Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If there is only one file for named entry, pass it directly #167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakub300
Copy link

@jakub300 jakub300 commented Nov 3, 2017

Hey,

Currently webpack-steam always passes files for named entry as an array. Because of that webpack is creating dummy module and all it does is requiring our main file, for example:

/***/ 4:
/***/ (function(module, exports, __webpack_require__) {

module.exports = __webpack_require__(5);


/***/ }),

It is ugly and what's worse that module is does not receive id from HashedModuleIdsPlugin (that's what lead me to discovery of current behaviour). This PR fixes it by extracting first element from the array if the array has only one element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant