Skip to content

Commit

Permalink
ci: Do not persist credentials after checkout (#71)
Browse files Browse the repository at this point in the history
See actions/checkout#485 and
https://johnstawinski.com/2024/01/11/playing-with-fire-how-we-executed-a-critical-supply-chain-attack-on-pytorch/

In short, it is a terrible idea to persist even our default credentials
after checkout. There's no call for that, so we will now set
`persist-credentials: false` on all checkout actions.
  • Loading branch information
joeyparrish authored Dec 18, 2024
1 parent c038b63 commit d0f1d1a
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: true
persist-credentials: false

- name: Install deps
run: |
Expand Down Expand Up @@ -99,6 +100,8 @@ jobs:
runs-on: windows-latest
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Set version number
shell: bash
Expand Down Expand Up @@ -196,6 +199,8 @@ jobs:
with:
repository: '${{ secrets.HOMEBREW_TAP_REPO }}'
fetch-depth: 0 # The entire repo history, so we can push an update
# To push to this repo, an explicit token is used to authenticate.
persist-credentials: false

- name: Wipe source and formula folders
run: |
Expand All @@ -211,6 +216,7 @@ jobs:
uses: actions/checkout@v4
with:
path: shaka-lab-source
persist-credentials: false

- name: Finish staging tap repo
run: |
Expand Down

0 comments on commit d0f1d1a

Please sign in to comment.