Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace Remote Explorer instruction with Ports tab #112

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alisonjo315
Copy link

@alisonjo315 alisonjo315 commented Feb 17, 2023

The Problem/Issue/Bug

See issue.

How this PR Solves The Problem

Updates instructions to point to "Ports" tab instead of "Remote Explorer" button.

Manual Testing Instructions

Related Issue Link(s)

Closes #111

Release/Deployment notes

Summary by CodeRabbit

"Documentation: Updated user instructions for accessing Drupal services in the DrupalPod extension for VSCode. Users are now directed to the 'Ports' tab instead of the 'Remote Explorer' button. This change simplifies the process of opening Drupal in a new tab or window by clicking the 'Globe' button next to the '8080' item in the list."

@codesandbox
Copy link

codesandbox bot commented Feb 17, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@ghost
Copy link

ghost commented Feb 17, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

@mradcliffe mradcliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@rodrigoaguilera
Copy link

Thanks @alisonjo315
Can you also change the arrow to point down where the ports tab is located?

The rest of the change look good to me.

It would be great to have this before Drupalcon Lille since I remember some confusion with first-time contributors about this.

cc @shaal

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 8, 2023

Walkthrough

This change simplifies the user experience by directing them to the "Ports" tab instead of the "Remote Explorer" button. It streamlines the process of accessing Drupal services provided by DrupalPod, specifically the service running on port 8080.

Changes

File Summary
.../drupalpod-ext/src/help-content.ts Replaced instructions to use "Remote Explorer" button with a directive to navigate to the "Ports" tab. Users are guided to find the "8080" item and press the "Globe" button to open Drupal in a new tab or window.

🐇

"In the land of code, where logic is the road,

Changes come and go, as the knowledge flows.

To the Ports we now steer, leaving no user in fear,

For the Globe is near, and Drupal's cheer is here!" 🌐🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 0efc728 and 5142d21.
Files selected for processing (1)
  • src/vscode-extension/drupalpod-ext/src/help-content.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/vscode-extension/drupalpod-ext/src/help-content.ts

@alisonjo315
Copy link
Author

@rodrigoaguilera lol good catch! -- done 😁

@alisonjo315 alisonjo315 requested a review from mradcliffe October 8, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Started: Update instructions for making 8080 public
3 participants