Fix tests and update docs

Fixes #45
serpro69 · Apr 28, 2021 · cace76d · cace76d
1 parent 5d444ef
commit cace76d
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format follows [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and the project versioning adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html) 
 
+## [v1.7.1] - 2020-04-28
+### Fixed
+- [#45](https://github.com/serpro69/kotlin-faker/pull/45) [core] Parameter 'city_name' not found in 'address'
+
 ## [v1.7.0] - 2020-04-16
 ### Added
 - [#59](https://github.com/serpro69/kotlin-faker/pull/59) [core] Random money amount

diff --git a/...t/src/main/resources/META-INF/native-image/io.github.serpro69/cli-bot/reflect-config.json b/...t/src/main/resources/META-INF/native-image/io.github.serpro69/cli-bot/reflect-config.json
@@ -237,8 +237,9 @@
   "name":"io.github.serpro69.kfaker.provider.Address",
   "methods":[
     {"name":"buildingNumber","parameterTypes":[] }, 
-    {"name":"city","parameterTypes":[] }, 
-    {"name":"cityWithState","parameterTypes":[] }, 
+    {"name":"city","parameterTypes":[] },
+    {"name":"cityName","parameterTypes":[] },
+    {"name":"cityWithState","parameterTypes":[] },
     {"name":"community","parameterTypes":[] }, 
     {"name":"country","parameterTypes":[] }, 
     {"name":"countryByCode","parameterTypes":["java.lang.String"] }, 

diff --git a/cli-bot/src/test/kotlin/io/github/serpro69/kfaker/app/cli/IntrospectorTest.kt b/cli-bot/src/test/kotlin/io/github/serpro69/kfaker/app/cli/IntrospectorTest.kt
@@ -380,6 +380,7 @@ class IntrospectorTest : DescribeSpec() {
                     val expectedFunctions = listOf(
                         "buildingNumber",
                         "city",
+                        "cityName",
                         "cityWithState",
                         "community",
                         "country",

diff --git a/core/src/test/kotlin/io/github/serpro69/kfaker/TestConstants.kt b/core/src/test/kotlin/io/github/serpro69/kfaker/TestConstants.kt
@@ -183,6 +183,7 @@ val addressCategoryKeys = listOf(
     "state_abbr",
     "time_zone",
     "city",
+    "city_name",
     "city_with_state",
     "street_name",
     "street_address",

diff --git a/doc/address.md b/doc/address.md
@@ -39,6 +39,9 @@ Faker().address.timeZone() // => Pacific/Midway
 
 Faker().address.city() // => Bartville
 
+// This one is the same as 'city' and is added to fix discrepancies between localized and English dictionaries (see #45)
+Faker().address.cityName() // => Bartville
+
 Faker().address.cityWithState() // => Bartville, Indiana
 
 Faker().address.streetName() // => Adams Brook