Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not leak let bind and force Stdlib usage #33

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

tjdevries
Copy link
Collaborator

Previously, whenever you use serde derive, you leak let* binding. Also, if you have something that shadows Option or Result open at the time of using it, you can get an error.

Copy link
Member

@leostera leostera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leostera leostera merged commit 89b60d6 into main Jul 3, 2024
0 of 4 checks passed
@leostera leostera deleted the cleaner-namespace branch July 3, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants