Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Tighten webpack rule merge rules to prevent clashes (#376)" #379

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Nov 18, 2024

Revert #376. This was causing issues with our internal usage of playroom. We rely on overriding playroom's .css file loading, but making the webpack merge rules stricter has made it impractical to override this rule (it required explicitly targeting codemirror within playroom's node modules). See #376 (comment) for further discussion.

@askoufis askoufis requested a review from a team as a code owner November 18, 2024 04:03
Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: e2f6ef3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@askoufis askoufis enabled auto-merge (squash) November 18, 2024 04:05
@askoufis askoufis merged commit a6895e0 into master Nov 18, 2024
6 checks passed
@askoufis askoufis deleted the revert-webpack-merge-change branch November 18, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants