Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): ensure views of anndata produce distinguishable view classes #1637

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ilan-gold
Copy link
Contributor

  • Closes #
  • Tests added
  • Release note added (or unnecessary)

@ilan-gold ilan-gold changed the title (chore): ensure views of anndata produce view classes (chore): ensure views of anndata produce distinguishable view classes Sep 2, 2024
@ilan-gold ilan-gold added this to the 0.11.0 milestone Sep 2, 2024
@ilan-gold
Copy link
Contributor Author

ilan-gold commented Sep 2, 2024

@flying-sheep Happy to add a protocol here for having base if you think that's the way to go. I am a bit ambivalent - this solution is perhaps less robust but requires exposing less API surface area.

Without API change, can go in a patch as well

@ilan-gold ilan-gold modified the milestones: 0.11.0, 0.10.10 Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.33%. Comparing base (2e3ab38) to head (45b5300).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1637      +/-   ##
==========================================
- Coverage   86.81%   84.33%   -2.49%     
==========================================
  Files          37       37              
  Lines        6008     6008              
==========================================
- Hits         5216     5067     -149     
- Misses        792      941     +149     
Files with missing lines Coverage Δ
src/anndata/_core/views.py 85.33% <100.00%> (-5.78%) ⬇️

... and 7 files with indirect coverage changes

@ilan-gold ilan-gold modified the milestones: 0.10.10, 0.11.1, 0.11.2 Nov 7, 2024
@flying-sheep
Copy link
Member

Hmm, good question.

I think if possible I’d prefer exporting _SetItemMixin under a different name. Maybe something containing COW (copy-on-write) to clarify semantics?

But it might not be possible to do that since python/typing#213 isn’t implemented yet. We might want to add our use case to https://github.com/CarliJoy/intersection_examples/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants