-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: truncate long channel names on data_mc plots #496
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #496 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2093 2093
Branches 346 346
=========================================
Hits 2093 2093 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, that's a good idea, thanks for improving this! The new behavior is better than the old and anyone needing more control over the string can edit the figure externally with matplotlib
of course.
One very picky comment, can we go with an f-string here to be consistent with the rest of the codebase?
f"{label[:30]}..."
0ce3b1d
to
d72257f
Compare
There's an extra space before the "..." now which might be a bit confusing? I think it makes more sense without the space as in the original picture. |
I left this intentionally, so that it is separated from the actual name. But I'll change it if you prefer. |
d72257f
to
cfc43c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel super strongly, just thought that depending on where the cutoff happens it might end up looking like the region name is done and some other information was cut out instead. The ...
without space is less clear in that regard I believe.
Happy to merge this, thanks again!
* only show first 30 characters of channel names on data/MC plots
Hey,
I realized that figures become unusable for long channel names:
I implemented a small fix for this, which results in: