Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add convenience method for Zulu JDKs #186

Closed
wants to merge 1 commit into from

Conversation

SethTisue
Copy link
Member

since I can JavaSpec.temurin, I would like to be able to JavaSpec.zulu as well

@SethTisue
Copy link
Member Author

SethTisue commented Jun 23, 2024

ha, well this is very meta — CI is failing because of the same issue that brought me here in the first place, namely actions/setup-java#625 — macOS-latest doesn't offer temurin@8 anymore, you have to zulu@8

@SethTisue
Copy link
Member Author

not sure how we want to handle this. do we want the entire plugin to now default to zulu@8 instead of temurin@8? or should we only default to zulu on MacOS specifically? 🤷

@SethTisue SethTisue marked this pull request as draft June 23, 2024 03:35
@eed3si9n
Copy link
Member

I've default everything to zulu@8 in #187

@SethTisue
Copy link
Member Author

superseded by #187, thank you Eugene!

@SethTisue SethTisue closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants