Release 0.12.0 #202
Merged
Release 0.12.0 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
reviewed
Dec 16, 2023
Co-authored-by: Daniel McCarney <[email protected]>
|
There is no changes to the version in |
|
As a small note, in the future I'd like a chance to approve the changelog before the release is published if I leave feedback. If I don't reply right away it seems reasonable to roll forward without waiting.
That sounds fine to me. In the other Rustls repos we tend to use -alpha.0 but I don't feel strongly. |
Sorry, noted! |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
From the release 0.12 of rcgen #202 , we must now choose `ring` or `aws_lc_rc` as a feature. Because `rustls_cert_gen` has `default-features = false`, its build is currently broken. This PR activate `aws_lc_rc` feature, because soon it will get RSA key generation support aws/aws-lc-rs#296 , so it will provide more options. But we could also change it to default to whatever `rcgen` default or use `ring` as default depending on your preferences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For release notes see the changelog.
fixes #199