Fix MonitorHandle PartialEq and Hash on iOS
#4013
Merged
+37
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
madsmtm/monitor-comparisons
branch
2 times, most recently
from
69c21f3 to
88ce1eb
Compare
madsmtm
force-pushed
the
madsmtm/monitor-comparisons
branch
from
88ce1eb to
fb0dc36
Compare
kchibisov
approved these changes
Dec 3, 2024
kchibisov
pushed a commit
that referenced
this pull request
Dec 16, 2024
kchibisov
pushed a commit
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See bevyengine/bevy#16541, we were comparing the pointer addresses of
MonitorHandle(which changes every time a new one is created) instead ofUIScreen(which is more stable).TODO: