Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Integer.dec() and Integer.inc() #53

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

MiguelX413
Copy link
Contributor

This PR seeks to solve #2. If merged, I also intend to manually implement these methods more optimally on BigInt and BigUint.

@cuviper
Copy link
Member

cuviper commented Feb 10, 2023

Hi - thanks for the PR. Even as trivial as these are, can you add some examples? (which will also serve as tests)

Maybe also add "by one" to the doc description.

@MiguelX413
Copy link
Contributor Author

Hi - thanks for the PR. Even as trivial as these are, can you add some examples? (which will also serve as tests)

Maybe also add "by one" to the doc description.

Sure!

@cuviper
Copy link
Member

cuviper commented Feb 8, 2024

I added the examples myself.

@cuviper cuviper added this pull request to the merge queue Feb 8, 2024
Merged via the queue into rust-num:master with commit 77324ee Feb 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants