Fix rails 8 build with 2781 and 2783 #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ory. Rails `main` uses Thor for the `bin/rails stats` command instead of Rake. This means stats directories need to be added in the Railtie. The global constant STATS_DIRECTORIES defined by Rails, has been deprecated in favor of Rails::CodeStatistics.register_directory. https://github.com/rails/rails/blob/8c7754dfdf39ed94cc93bbc40ee721c311b6d32c/railties/CHANGELOG.md?plain=1#L1-L11
Rails main requires `sqlite3` version 2: rails/rails#51958
JonRowe
force-pushed
the
fix-rails-8-with-2781-and-2783
branch
from
4f02747 to
5cb02ba
Compare
JonRowe
force-pushed
the
fix-rails-8-with-2781-and-2783
branch
from
5cb02ba to
d9dceef
Compare
|
Looks good to me! |
JonRowe
added a commit
that referenced
this pull request
Sep 2, 2024
Fix rails 8 build with 2781 and 2783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to see if combining #2781 and #2783 have a green build.