Replace OpenStruct dependency with Struct #2755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pirj this is ready and looking good. Can you please re-run the failed CI jobs? Those should pass. Reviewing each, it's the same failure and I've seen on other builds so either a flaky and/or unrelated. Thank you for the suggestion. It's better than depending on OpenStruct. |
|
Thank you. This is indeed much better. |
JonRowe
pushed a commit
that referenced
this pull request
Apr 10, 2024
Replace OpenStruct dependency with Struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of reverting #2754 since it will still fail, this is a new attempt at replacing the OpenStruct dependency with a Struct from this suggestion: #2754 (comment)