Devcontainer on Az CLI 2.37 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replacing openid extension with OAuth2-proxy * client id, client secret and cookie secret are passed using env vars so it wont print * revert cookie secret change * fixing versions * Add token validation * Remove unused imports * fix docs * Fix oauth_proxy_email_domain to astreix * linter issues * Fix the E2E tests and add the new attributes for the new guacamole oauth proxy (#1681) * add new attributes to payload * remove email domain * TEST_WORKSPACE_SECRET Co-authored-by: Anat Balzam <[email protected]> * skip provider button * pr comments * PR comments * add refresh cookie Co-authored-by: Anat Balzam <[email protected]> Co-authored-by: Anat Balzam <[email protected]>
* Add API creds into KeyVault so that RP can read it * Make this behaviour configurable * workspace_creation_app_* parameters for RP * App Service uses keyvault for the API credentials * Terraform fmt * Remove extra line * Recover my key vault!
* Exit with successful status if RG not found * Add az login for destroy steps * Remove redundant step conditions
* API App has Application ReadWrite.All * applicationReadWriteAll
* Upgrade workspace AzureRM provider * Missing shbang
* Add GitHub script to capture PR info Capture info and dump to compare with existing method of generation Update tests to create new mock per test for more reliable Called assertions * Make indentation consistent
* Rename auth file * Increased version
* Update command handling Assume that a first line starting with a slash is intended to be treated as a command and output help if not recognised * Remove previous help output from yml * Use core for logging, validate outputs are set correctly * Simplify test context setup * Move to using GitHub script outputs for pr details * Remove redundant step * Add reply comment when user cannot run commands * Switch to using output for command The linter was reporting failures when referencing additional outputs from the GitHub script action. Previously, we set the command as the action result and set the result type as string. This change switches to setting an output for the command explicitly, and reinstates the result type as object * Move to later super-linter to get actionlint update * Revert "Move to later super-linter to get actionlint update" This reverts commit 93a09b454733a87b924baea04f0674962c5b8301. It seems that the latest version of the super-linter action still pulls the v4.9.2 container which doesn't have the latest actionlint * Add actionlint to build script tests * Temporarily disable GitHub action linting in super-linter * Add missing awaits on github SDK calls * Move "running tests" comment to GitHub script * Handle docs-only check in GitHub script Bonus: allows for including 'mkdocs.yml' as a docs file * Use addActionComment for show-help Add more consistency around pr-bot messages * Add comment on /test-force-approve * Include commit SHA in /test-force-approve comment * Include refid (part of RG name) in comment for /test * Add pointer to run-test.sh
* workspace auth migration script * Add semantic version check to run later * Add the db-migrate as part of the build
* Add API creds into KeyVault so that RP can read it * Make this behaviour configurable * workspace_creation_app_* parameters for RP * App Service uses keyvault for the API credentials * Terraform fmt * Remove extra line * AAD Managed by Workspace creation * Terraform fmt * Conditional creation of AAD * Purge Protection off when debugging * Porter flag to create Workspace AAD App * Linting * Linting (again!) * Uninstall workspace works * workspace-creation-creds.json * Revert keyvault purge check * No longer use aad.json * Missing Api Id returns 500 * Make app_id mandatory * Rename auth file * Consolidated into base workspace * AAD outputs * Output AAD info from porter workspace creation * Renamed the aad_auth.json file * Moving authInformation into workspace properties * Fix shellcheck * ShellCheck * Put authInformation back to previous state * Linting * Recover Soft Deleted Keys * Explicit AppRoleIds * api_id is defined in a different file * PR comments * RP version * Increased api version
* Refactor classes * reorganize tests + adding new tests * change version of guac server * add package-info.java + lint * add package-info.java + lint * Add getUserContext tests * Fix refresh list Co-authored-by: Anat Balzam <[email protected]>
* dev-vm added from linux-vm to avoid polluting real user_resources * initial docs * gaaaaaaaa api version * Update pipeline-schema.md Linting MD * bash linting * shellcheck * +x * linting * fixed import * ops doc updated * creating steps, default main step * initial patch logic * submit post for user_resource succeeds * happy path manually tested * create / update / delete for all resource types * fixed up unit tests * e2e extended passing * etag retrying and swagger specs update * operation item creation unit test * added unit tests for multi-step * rp version bump * api version bump again * returning resource_to_send * api bump * pr feedback * api v£ * versions£
* Remove outputs from base workspace (for now) * Shouldn't have changed this file
* Use Current dir when referencing paths in makefile * Fix merge issue * CR changes Co-authored-by: Liza Shakury <[email protected]>
* kv ref for oauth-proxy * Changed key vault fetch to user assigned * change name from ws to workspace Co-authored-by: Anat Balzam <[email protected]> Co-authored-by: Tamir Kamara <[email protected]>
* sync porter & azure cli versions * update exports
* app gw diag settings * keyvault diag settings * format fix
* Add `/test <sha` command Add test helpers to improve test readability * Make command tests more consistent * Add comment on running test, update run-test.sh * Extract /test command handling to separate function * Add SHA validation for external PRs for /test-extended * Update maintainers.md with /test sha requirements * Add tests for non-mergeable PRs * Handle extra spaces between /test and sha When copy/pasting SHA in UI, it's easy to add an extra space This change makes the pr-bot tolerant of that * PR feedback
* disable purge for guacamole secrets * fix pytest marker
* Migrate database * Move db-migrate to tre-deploy step * Only source the .env if you have one * Only migrate if ENABLE_LOCAL_DEBUGGING * Removed migrate from the build b/c network * flake8
* Don't use Owner * renamed variable to, for Marcus
Bumps [moment](https://github.com/moment/moment) from 2.29.3 to 2.29.4. - [Release notes](https://github.com/moment/moment/releases) - [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md) - [Commits](moment/moment@2.29.3...2.29.4) --- updated-dependencies: - dependency-name: moment dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ross Smith <[email protected]> Co-authored-by: Martin Peck <[email protected]>
* Remove EventGrid temp fix * Check core version updates in ci
* Pass emails to notifications * Fix unit tests. * Fix lint issues * Fix port Co-authored-by: Liza Shakury <[email protected]>
…AzureTRE into ross/adminconsent2.37
* switch lstrip with replace * bump version
* Fix python replace bug * version bump
* Added actionDisabled states * Removed unused imports
* fix left nav scroll * uiSchema in templates and UI * api v
ross-p-smith
added a commit
that referenced
this pull request
Jul 13, 2022
* Removed scripts folder * Linting * Linting #3 * Added in build step * PR comment * Revert db-migrate * Admin Consent * Workspace Admin Consent * Removed unsued variables * Split AAD scripts up * Working on bash read prompt * Add a final check * Removing private file * Moving to Az cli 2.37 for Graph * Removed appName from credential reset * update_resource_access * Remove AAD_TENANT_ID * Rp should use 2.37 az cli * increase mgmt AzureRM version * Bump version * Pinning versions of apt-get packages * pipe and copy * WORKDIR * Move requirements to /tmp folder * --no-install-recommends * --no-install-recommends
ross-p-smith
added a commit
that referenced
this pull request
Jul 14, 2022
…matically. (microsoft#2259) * Removed scripts folder * Linting * Linting #3 * Added in build step * PR comment * Revert db-migrate * Admin Consent * Workspace Admin Consent * Removed unsued variables * Split AAD scripts up * Working on bash read prompt * Add a final check * Removing private file * Moving to Az cli 2.37 for Graph * Removed appName from credential reset * update_resource_access * Remove AAD_TENANT_ID * Rp should use 2.37 az cli * increase mgmt AzureRM version * Bump version * Pinning versions of apt-get packages * pipe and copy * WORKDIR * Move requirements to /tmp folder * --no-install-recommends * --no-install-recommends * Create auth.env * removed debug * Update documentation * Bump version * Merge the .env files for local debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue 1645
What is being addressed
Use Az CLI 2.37 in the DevContainer
Implications