Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot Mode with Duration #1795

Closed
johnsonTyler0511 opened this issue Aug 28, 2024 · 1 comment
Closed

Snapshot Mode with Duration #1795

johnsonTyler0511 opened this issue Aug 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@johnsonTyler0511
Copy link

Description

I am using ros2 bag record in snapshot-mode and I want to be able to use both a max size for the bag file and a duration to split the bag files up by.

Currently with snapshot-mode and setting a max_bag_duration I end up getting bag files with no messages but has some metadata about topics etc.

it would be great if the bag files would not be created until the snapshot service was called and then they get split by duration and size as normal 👍

Completion Criteria

snapshot-mode supports max_bag_duration argument with max_bag_size

Implementation Notes / Suggestions

Possibly look through the cache and split based on time in topic messages

Testing Notes / Suggestions

  • test snapshot-mode with duration does not make empty bag files
  • test snapshot-mode with duration splits bags based on time between messages in the cache
@johnsonTyler0511 johnsonTyler0511 added the enhancement New feature or request label Aug 28, 2024
@emersonknapp
Copy link
Collaborator

Closing as duplicate of #900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants