Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_zero_initialized_xxx functions return zero initialized structure. #380

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Open

get_zero_initialized_xxx functions return zero initialized structure. #380

wants to merge 2 commits into from

Conversation

fujitatomoya
Copy link
Collaborator

@fujitatomoya fujitatomoya commented Oct 11, 2024 •
edited
Loading

replaces #379

and follow up #378

Important

This needs to be merged with ros2/rmw_connextdds#162, ros2/rmw_fastrtps#785 and ros2/rmw_cyclonedds#518

fujitatomoya
fujitatomoya commented Oct 11, 2024
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette can you take a look?

rmw/src/event.c Show resolved Hide resolved
rmw/src/init_options.c Show resolved Hide resolved
rmw/src/init_options.c Show resolved Hide resolved
rmw/src/init_options.c Show resolved Hide resolved
@fujitatomoya
Copy link
Collaborator Author

Pulls: #380
Gist: https://gist.githubusercontent.com/fujitatomoya/511ae3290eaf698932f4a234e72c2db4/raw/51a991ad78ac2e0c9e5df8765db826a6ff8e014a/ros2.repos
BUILD args: --packages-above-and-dependencies rmw
TEST args: --packages-above rmw
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14692

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

clalancette
clalancette reviewed Oct 11, 2024
View reviewed changes
rmw/src/event.c Show resolved Hide resolved
rmw/test/test_event.cpp Outdated Show resolved Hide resolved
rmw/test/test_event.cpp Outdated Show resolved Hide resolved
This was referenced Oct 11, 2024
Open
Open
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/return-zero-structure branch from e64a877 to 092cb5c Compare October 11, 2024 15:47
@fujitatomoya
Copy link
Collaborator Author

@clalancette totally agree with your review comments, thanks. all comments are resolved, ready to review.

@fujitatomoya
Copy link
Collaborator Author

Pulls: #380, ros2/rmw_connextdds#162, ros2/rmw_fastrtps#785
Gist: https://gist.githubusercontent.com/fujitatomoya/287bc10787b6388b8c13bf6fdfa4d974/raw/ec909bd20c342c882a27450c57dc05ce62d209b5/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_connextdds_common rmw_fastrtps_shared_cpp
TEST args: --packages-above rmw rmw_connextdds_common rmw_fastrtps_shared_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14697

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya mentioned this pull request Oct 16, 2024
Open
@fujitatomoya
Copy link
Collaborator Author

Pulls: #380, ros2/rmw_fastrtps#785, ros2/rmw_connextdds#162, ros2/rmw_cyclonedds#518
Gist: https://gist.githubusercontent.com/fujitatomoya/a5a27e64c97e3b687ed9c85018393aef/raw/398849da025367226392ce4eacd4f8114a09b768/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
TEST args: --packages-above rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14711

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

the CI failure is missing ros2/rmw_fastrtps@8fd6f3c, we need to rebase and restart the CI.

@fujitatomoya
Copy link
Collaborator Author

Pulls: #380, ros2/rmw_fastrtps#785, ros2/rmw_connextdds#162, ros2/rmw_cyclonedds#518
Gist: https://gist.githubusercontent.com/fujitatomoya/6abc026e02c2c115a589c04c79e23c39/raw/398849da025367226392ce4eacd4f8114a09b768/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
TEST args: --packages-above rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14714

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

Linux-aarch64 and Windows CIs were not started successfully with some reason, and RHEL is known issue. i will start the CI for all platform once again.

@fujitatomoya
Copy link
Collaborator Author

Pulls: #380, ros2/rmw_fastrtps#785, ros2/rmw_connextdds#162, ros2/rmw_cyclonedds#518
Gist: https://gist.githubusercontent.com/fujitatomoya/82891bb189950fefcf68c0f191365af1/raw/398849da025367226392ce4eacd4f8114a09b768/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
TEST args: --packages-above rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14720

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

Pulls: #380, ros2/rmw_fastrtps#785, ros2/rmw_connextdds#162, ros2/rmw_cyclonedds#518
Gist: https://gist.githubusercontent.com/fujitatomoya/16961ebf1f4059173817c9730b42d685/raw/398849da025367226392ce4eacd4f8114a09b768/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
TEST args: --packages-above rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14722

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Oct 19, 2024 •
edited
Loading

Pulls: #380, ros2/rmw_fastrtps#785, ros2/rmw_connextdds#162, ros2/rmw_cyclonedds#518
Gist: https://gist.githubusercontent.com/fujitatomoya/065211cb8895027ee0a710a50b6a9851/raw/398849da025367226392ce4eacd4f8114a09b768/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
TEST args: --packages-above rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14726

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

@clalancette can you take an another look at this?

@fujitatomoya
Copy link
Collaborator Author

@clalancette i addressed all of the comments, please take a look at them when you have time.

@fujitatomoya
Copy link
Collaborator Author

@clalancette friendly ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methylDragon methylDragon Awaiting requested review from methylDragon

@ivanpauno ivanpauno Awaiting requested review from ivanpauno

@wjwwood wjwwood Awaiting requested review from wjwwood

@clalancette clalancette Awaiting requested review from clalancette

Assignees

@clalancette clalancette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fujitatomoya @clalancette