[FEA] Add manual call policy according with FIFO and timestamp. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clalancette @gbiggs friendly ping for updates. |
ahcorde
requested changes
Jul 30, 2024
| @@ -0,0 +1,131 @@ | |||
| /********************************************************************* | |||
There was a problem hiding this comment.
please use hpp extension instead of h.
Comment on lines
+43
to
+47
| #include "message_filters/connection.h" | ||
| #include "message_filters/message_traits.h" | ||
| #include "message_filters/null_types.h" | ||
| #include "message_filters/signal9.h" | ||
| #include "message_filters/synchronizer.h" |
| * It is up to the programmer to call #call when it is time to process the information. This policy class | ||
| * is meant to be used in networks where information is processed periodically. | ||
| */ | ||
| template<typename M0, typename M1, typename M2 = NullType, typename M3 = NullType, typename M4 = NullType, |
There was a problem hiding this comment.
use variadoc templates like in this PR https://github.com/ros2/message_filters/pull/93/files
In the others files as well
| /********************************************************************* | ||
| * Software License Agreement (BSD License) | ||
| * | ||
| * Copyright (c) 2009, Willow Garage, Inc. |
There was a problem hiding this comment.
in this correct? you can use 2024 and Open Robotics
| header.stamp = stamp; | ||
| } | ||
| }; | ||
| typedef std::shared_ptr<Msg> MsgPtr; |
| ASSERT_TRUE(helper.e1_ == evt_2); | ||
| ASSERT_TRUE(helper.e2_ == evt_2_hl); | ||
| ASSERT_TRUE(helper.e3_ == evt_3); | ||
| // |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue the work from PR #38 . Originally created by @jacobperron
The existing change requests in #38 are resolved.
UT passed, Please review @clalancette