Skip to content

Commit

Permalink
Update reviewers_due_date_responder_spec.rb (#5)
Browse files Browse the repository at this point in the history
  • Loading branch information
maelle authored Feb 24, 2021
1 parent 67a1c55 commit 7813fc7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/responders/ropensci/reviewers_due_date_responder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def add(reviewer)
new_list = (list_of_reviewers + [reviewer]).uniq
update_list("reviewers", new_list.join(", "))
update_list("due-dates", add_reviewer_due_date(reviewer).join("\n"))
respond("#{reviewer} added to the reviewers list. Review due date is #{due_date}")
respond("#{reviewer} added to the reviewers list. Review due date is #{due_date}. Thanks #{reviewer} for accepting to review! Please refer to [our reviewer guide](https://devguide.ropensci.org/reviewerguide.html).")
add_collaborator(reviewer) if add_as_collaborator?(reviewer)
add_assignee(reviewer) if add_as_assignee?(reviewer)
process_labeling if new_list.size == 2
Expand Down
4 changes: 2 additions & 2 deletions spec/responders/ropensci/reviewers_due_date_responder_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@
due_date = (Time.now + 10 * 86400).strftime("%Y-%m-%d")
expect(due_date.strip).to_not be_empty
expect(due_date).to_not eq(@new_due_date)
expect(@responder).to receive(:respond).with("@xuanxu added to the reviewers list. Review due date is #{due_date}")
expect(@responder).to receive(:respond).with("@xuanxu added to the reviewers list. Review due date is #{due_date}. Thanks @xuanxu for accepting to review! Please refer to [our reviewer guide](https://devguide.ropensci.org/reviewerguide.html).")
@responder.process_message(@msg)
end

it "should respond to github" do
expect(@responder).to receive(:respond).with("@xuanxu added to the reviewers list. Review due date is #{@new_due_date}")
expect(@responder).to receive(:respond).with("@xuanxu added to the reviewers list. Review due date is #{@new_due_date}. Thanks @xuanxu for accepting to review! Please refer to [our reviewer guide](https://devguide.ropensci.org/reviewerguide.html).")
@responder.process_message(@msg)
end

Expand Down

0 comments on commit 7813fc7

Please sign in to comment.