Inject credentials #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the 'include_context' method, used in several specs, isn't available before 2.6
Don't force the user to depend solely on a configuration file in the home directory. Now credentials may be supplied directly when calling ShortURL.shorten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't like the fact that credentials may only be provided using a configuration file in the home directory. As a solution I suggest inversion of control when dealing with credentials - the Service should not know where to ask for them, but expect them as provided on initialization. That makes it possible to supply them like
ShortURL.shorten 'http://oh.my/very/long/url', :bitly, {'username' => 'joe', 'key' => 'key123'}The code in the PR is just a quick proposal for now. If it was to be accepted, I would also provide tests that are now missing.