Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add json output, upgrade libraries and removes unsupported tests #1

Merged

Conversation

ritwikranjan
Copy link
Owner

@ritwikranjan ritwikranjan commented Sep 13, 2024

This pull request includes several updates to the network/benchmarks/netperf project, focusing on improving Dockerfile configuration, Makefile commands, and Kubernetes client interactions. The changes also include enhancements to the launch.go file to support JSON output and use context for Kubernetes API calls.

This tracks issue kubernetes#2876

Dockerfile and Makefile Updates:

  • Updated the Dockerfile to use golang:bullseye and simplified file copying steps.
  • Modified the Makefile to streamline the docker target and added a localtest target for local testing. [1] [2]

.gitignore Updates:

  • Added .json and kubeConfig to the .gitignore file to exclude these files from version control. [1] [2]

go.mod Updates:

  • Updated dependencies in go.mod to newer versions, ensuring compatibility with Go 1.23.

launch.go Enhancements:

  • Added support for JSON output alongside CSV data and used context for all Kubernetes API calls to improve code reliability and readability.

nptest.go Fixes:

  • Comment out qperf and iperf SCTP tests as they do not work with the current framework.
  • Adds some throuput tests that produce json output, we can extract those using the -json in launch.go

@ritwikranjan ritwikranjan force-pushed the improvements/experiment-1 branch from dfd63ba to aa02653 Compare September 13, 2024 16:06
@ritwikranjan ritwikranjan force-pushed the improvements/experiment-1 branch from aa02653 to a3cb332 Compare September 13, 2024 16:08
@ritwikranjan ritwikranjan merged commit 33d3099 into kubernetes-perf-tests-issues-#2876 Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant