Skip to content

rhboot/shim-review

BranchesTags

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

61 Commits
docs
docs
 
 
examples
examples
 
 
.gitignore
.gitignore
 
 
CODE_OF_CONDUCT.md
CODE_OF_CONDUCT.md
 
 
ISSUE_TEMPLATE.md
ISSUE_TEMPLATE.md
 
 
README.md
README.md
 
 

Repository files navigation

This repo is for review of requests for signing shim. To create a request for review:

  • clone this repo (preferably fork it)
  • edit the template below
  • add the shim.efi to be signed
  • add build logs
  • add any additional binaries/certificates/SHA256 hashes that may be needed
  • commit all of that
  • tag it with a tag of the form "myorg-shim-arch-YYYYMMDD"
  • push it to GitHub
  • file an issue at https://github.com/rhboot/shim-review/issues with a link to your tag
  • approval is ready when the "accepted" label is added to your issue

Note that we really only have experience with using GRUB2 or systemd-boot on Linux, so asking us to endorse anything else for signing is going to require some convincing on your part.

Hint: check the docs directory in this repo for guidance on submission and getting your shim signed.

Here's the template:

What organization or people are asking to have this signed?

Organization name and website:
[your text here]

What's the legal data that proves the organization's genuineness?

The reviewers should be able to easily verify, that your organization is a legal entity, to prevent abuse. Provide the information, which can prove the genuineness with certainty.

Company/tax register entries or equivalent:
(a link to the organization entry in your jurisdiction's register will do)

[your text here]

The public details of both your organization and the issuer in the EV certificate used for signing .cab files at Microsoft Hardware Dev Center File Signing Services.
(not the CA certificate embedded in your shim binary)

Example:

Issuer: O=MyIssuer, Ltd., CN=MyIssuer EV Code Signing CA
Subject: C=XX, O=MyCompany, Inc., CN=MyCompany, Inc.

[your text here]

What product or service is this for?

[your text here]

What's the justification that this really does need to be signed for the whole world to be able to boot it?

[your text here]

Why are you unable to reuse shim from another distro that is already signed?

[your text here]

Who is the primary contact for security updates, etc.?

The security contacts need to be verified before the shim can be accepted. For subsequent requests, contact verification is only necessary if the security contacts or their PGP keys have changed since the last successful verification.

An authorized reviewer will initiate contact verification by sending each security contact a PGP-encrypted email containing random words. You will be asked to post the contents of these mails in your shim-review issue to prove ownership of the email addresses and PGP keys.

  • Name:
  • Position:
  • Email address:
  • PGP key fingerprint:

(Key should be signed by the other security contacts, pushed to a keyserver like keyserver.ubuntu.com, and preferably have signatures that are reasonably well known in the Linux community.)

Who is the secondary contact for security updates, etc.?

  • Name:
  • Position:
  • Email address:
  • PGP key fingerprint:

(Key should be signed by the other security contacts, pushed to a keyserver like keyserver.ubuntu.com, and preferably have signatures that are reasonably well known in the Linux community.)

Were these binaries created from the 15.8 shim release tar?

Please create your shim binaries starting with the 15.8 shim release tar file: https://github.com/rhboot/shim/releases/download/15.8/shim-15.8.tar.bz2

This matches https://github.com/rhboot/shim/releases/tag/15.8 and contains the appropriate gnu-efi source.

Make sure the tarball is correct by verifying your download's checksum with the following ones:

a9452c2e6fafe4e1b87ab2e1cac9ec00  shim-15.8.tar.bz2
cdec924ca437a4509dcb178396996ddf92c11183  shim-15.8.tar.bz2
a79f0a9b89f3681ab384865b1a46ab3f79d88b11b4ca59aa040ab03fffae80a9  shim-15.8.tar.bz2
30b3390ae935121ea6fe728d8f59d37ded7b918ad81bea06e213464298b4bdabbca881b30817965bd397facc596db1ad0b8462a84c87896ce6c1204b19371cd1  shim-15.8.tar.bz2

Make sure that you've verified that your build process uses that file as a source of truth (excluding external patches) and its checksum matches. Furthermore, there's a detached signature as well - check with the public key that has the fingerprint 8107B101A432AAC9FE8E547CA348D61BC2713E9F that the tarball is authentic. Once you're sure, please confirm this here with a simple yes.

A short guide on verifying public keys and signatures should be available in the docs directory.

[your text here]

URL for a repo that contains the exact code which was built to result in your binary:

Hint: If you attach all the patches and modifications that are being used to your application, you can point to the URL of your application here (https://github.com/YOUR_ORGANIZATION/shim-review).

You can also point to your custom git servers, where the code is hosted.

[your url here]

What patches are being applied and why:

Mention all the external patches and build process modifications, which are used during your building process, that make your shim binary be the exact one that you posted as part of this application.

[your text here]

Do you have the NX bit set in your shim? If so, is your entire boot stack NX-compatible and what testing have you done to ensure such compatibility?

See https://techcommunity.microsoft.com/t5/hardware-dev-center/nx-exception-for-shim-community/ba-p/3976522 for more details on the signing of shim without NX bit.

[your text here]

What exact implementation of Secure Boot in GRUB2 do you have? (Either Upstream GRUB2 shim_lock verifier or Downstream RHEL/Fedora/Debian/Canonical-like implementation)

Skip this, if you're not using GRUB2.

[your text here]

Do you have fixes for all the following GRUB2 CVEs applied?

Skip this, if you're not using GRUB2, otherwise make sure these are present and confirm with yes.

[your text here]

If shim is loading GRUB2 bootloader, and if these fixes have been applied, is the upstream global SBAT generation in your GRUB2 binary set to 4?

Skip this, if you're not using GRUB2, otherwise do you have an entry in your GRUB2 binary similar to:
grub,4,Free Software Foundation,grub,GRUB_UPSTREAM_VERSION,https://www.gnu.org/software/grub/?

[your text here]

Were old shims hashes provided to Microsoft for verification and to be added to future DBX updates?

Does your new chain of trust disallow booting old GRUB2 builds affected by the CVEs?

If you had no previous signed shim, say so here. Otherwise a simple yes will do.

[your text here]

If your boot chain of trust includes a Linux kernel:

Is upstream commit 1957a85b0032a81e6482ca4aab883643b8dae06e "efi: Restrict efivar_ssdt_load when the kernel is locked down" applied?

Is upstream commit 75b0cea7bf307f362057cc778efe89af4c615354 "ACPI: configfs: Disallow loading ACPI tables when locked down" applied?

Is upstream commit eadb2f47a3ced5c64b23b90fd2a3463f63726066 "lockdown: also lock down previous kgdb use" applied?

Hint: upstream kernels should have all these applied, but if you ship your own heavily-modified older kernel version, that is being maintained separately from upstream, this may not be the case.
If you are shipping an older kernel, double-check your sources; maybe you do not have all the patches, but ship a configuration, that does not expose the issue(s).

[your text here]

How does your signed kernel enforce lockdown when your system runs

with Secure Boot enabled?

Hint: If it does not, we are not likely to sign your shim.

[your text here]

Do you build your signed kernel with additional local patches? What do they do?

[your text here]

Do you use an ephemeral key for signing kernel modules?

If not, please describe how you ensure that one kernel build does not load modules built for another kernel.

[your text here]

If you use vendor_db functionality of providing multiple certificates and/or hashes please briefly describe your certificate setup.

If there are allow-listed hashes please provide exact binaries for which hashes are created via file sharing service, available in public with anonymous access for verification.

[your text here]

If you are re-using the CA certificate from your last shim binary, you will need to add the hashes of the previous GRUB2 binaries exposed to the CVEs mentioned earlier to vendor_dbx in shim. Please describe your strategy.

This ensures that your new shim+GRUB2 can no longer chainload those older GRUB2 binaries with issues.

If this is your first application or you're using a new CA certificate, please say so here.

[your text here]

Is the Dockerfile in your repository the recipe for reproducing the building of your shim binary?

A reviewer should always be able to run docker build . to get the exact binary you attached in your application.

Hint: Prefer using frozen packages for your toolchain, since an update to GCC, binutils, gnu-efi may result in building a shim binary with a different checksum.

If your shim binaries can't be reproduced using the provided Dockerfile, please explain why that's the case, what the differences would be and what build environment (OS and toolchain) is being used to reproduce this build? In this case please write a detailed guide, how to setup this build environment from scratch.

[your text here]

Which files in this repo are the logs for your build?

This should include logs for creating the buildroots, applying patches, doing the build, creating the archives, etc.

[your text here]

What changes were made in the distro's secure boot chain since your SHIM was last signed?

For example, signing new kernel's variants, UKI, systemd-boot, new certs, new CA, etc..

Skip this, if this is your first application for having shim signed.

[your text here]

What is the SHA256 hash of your final shim binary?

[your text here]

How do you manage and protect the keys used in your shim?

Describe the security strategy that is used for key protection. This can range from using hardware tokens like HSMs or Smartcards, air-gapped vaults, physical safes to other good practices.

[your text here]

Do you use EV certificates as embedded certificates in the shim?

A yes or no will do. There's no penalty for the latter.

[your text here]

Do you add a vendor-specific SBAT entry to the SBAT section in each binary that supports SBAT metadata ( GRUB2, fwupd, fwupdate, systemd-boot, systemd-stub, shim + all child shim binaries )?

Please provide the exact SBAT entries for all binaries you are booting directly through shim.

Hint: The history of SBAT and more information on how it works can be found here. That document is large, so for just some examples check out SBAT.example.md

If you are using a downstream implementation of GRUB2 (e.g. from Fedora or Debian), make sure you have their SBAT entries preserved and that you append your own (don't replace theirs) to simplify revocation.

Remember to post the entries of all the binaries. Apart from your bootloader, you may also be shipping e.g. a firmware updater, which will also have these.

Hint: run objcopy --only-section .sbat -O binary YOUR_EFI_BINARY /dev/stdout to get these entries. Paste them here. Preferably surround each listing with three backticks (```), so they render well.

[your text here]

If shim is loading GRUB2 bootloader, which modules are built into your signed GRUB2 image?

Skip this, if you're not using GRUB2.

Hint: this is about those modules that are in the binary itself, not the .mod files in your filesystem.

[your text here]

If you are using systemd-boot on arm64 or riscv, is the fix for unverified Devicetree Blob loading included?

[your text here]

What is the origin and full version number of your bootloader (GRUB2 or systemd-boot or other)?

[your text here]

If your shim launches any other components apart from your bootloader, please provide further details on what is launched.

Hint: The most common case here will be a firmware updater like fwupd.

[your text here]

If your GRUB2 or systemd-boot launches any other binaries that are not the Linux kernel in SecureBoot mode, please provide further details on what is launched and how it enforces Secureboot lockdown.

Skip this, if you're not using GRUB2 or systemd-boot.

[your text here]

How do the launched components prevent execution of unauthenticated code?

Summarize in one or two sentences, how your secure bootchain works on higher level.

[your text here]

Does your shim load any loaders that support loading unsigned kernels (e.g. certain GRUB2 configurations)?

[your text here]

What kernel are you using? Which patches and configuration does it include to enforce Secure Boot?

[your text here]

What contributions have you made to help us review the applications of other applicants?

The reviewing process is meant to be a peer-review effort and the best way to have your application reviewed faster is to help with reviewing others. We are in most cases volunteers working on this venue in our free time, rather than being employed and paid to review the applications during our business hours.

A reasonable timeframe of waiting for a review can reach 2-3 months. Helping us is the best way to shorten this period. The more help we get, the faster and the smoother things will go.

For newcomers, the applications labeled as easy to review are recommended to start the contribution process.

[your text here]

Add any additional information you think we may need to validate this shim signing application.

[your text here]

About

Reviews of shim

Resources

Readme

Code of conduct

Code of conduct
Activity
Custom properties

Stars

67 stars

Watchers

41 watching

Forks

131 forks
Report repository

Releases

No releases published

Packages

No packages published

Contributors 18
+ 4 contributors