Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): Request only info for versions with the same major #33169

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zharinov
Copy link
Collaborator

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov
Copy link
Collaborator Author

image

Seems like some registries/proxies could return all versions no matter which major prefix we're querying. It leads us to increment major and fetch them over and over.

@zharinov zharinov requested a review from rarkins December 17, 2024 13:35
@zharinov zharinov requested a review from rarkins December 17, 2024 15:40
@zharinov
Copy link
Collaborator Author

It's confirmed that artifactory returns all versions in any major, so this is the fix

@rarkins
Copy link
Collaborator

rarkins commented Dec 17, 2024

@zharinov please test on public goproxy too, to reduce chances of regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants