Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager/gomod): option to always run go mod vendor #33066

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat(manager/gomod): option to always run go mod vendor #33066

wants to merge 13 commits into from
+111 −3

Conversation

omercnet
Copy link
Contributor

@omercnet omercnet commented Dec 12, 2024 •
edited by viceice
Loading

Changes

Adding an option to always run go mod vendor regardless of vendor dir

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@omercnet omercnet changed the title feat(manage/gomod): option to always run go mod vendor feat(manager/gomod): option to always run go mod vendor Dec 12, 2024
rarkins
rarkins requested changes Dec 13, 2024
View reviewed changes
lib/modules/manager/gomod/artifacts.ts Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
@omercnet
Copy link
Contributor Author

I wanna add another test to ensure go work vendor also applies if needed so don't merge yet

@omercnet omercnet requested review from rarkins and viceice December 13, 2024 22:27
rarkins
rarkins requested changes Dec 14, 2024
View reviewed changes
.eslintrc.js Outdated Show resolved Hide resolved
@omercnet omercnet requested a review from rarkins December 15, 2024 06:53
@omercnet omercnet requested a review from rarkins December 15, 2024 07:07
@omercnet
Copy link
Contributor Author

@rarkins @viceice thanks for the review, is anyone able to merge this?

@omercnet
Copy link
Contributor Author

@rarkins ?

@omercnet omercnet requested a review from rarkins December 18, 2024 19:10
@rarkins
Copy link
Collaborator

rarkins commented Dec 18, 2024

Waiting on @viceice approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice Awaiting requested review from viceice

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omercnet @rarkins @viceice