-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(maven): Unify fetching utilities #32999
base: main
Are you sure you want to change the base?
feat(maven): Unify fetching utilities #32999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we split this into smaller parts? it's pretty hard to understand all changes.
and I also think this is a feature because you drop the head requests. that doesn't look like a refactor to me. it's at least a fix.
refactor PRs are not causing releases, so they accumulate
I don't think so, since it would contain duplicate code and will require duplicate tests. |
Changes
Replace
checkResource
andcheckS3Resource
with updateddownloadMaven
function which supports everything we need: timestamps, private registry detection and, well, the content itselfContext
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: