feat(datasource): Add datasource for buildpack registry #32721
+321
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: HonkingGoose <[email protected]> Co-authored-by: Michael Kriese <[email protected]> Co-authored-by: Pavel Busko <[email protected]> Co-authored-by: Johannes Dillmann <[email protected]> Co-authored-by: Nicolas Bender <[email protected]>
viceice
changed the title
viceice
reviewed
Nov 26, 2024
lib/modules/datasource/buildpacks-registry/__fixtures__/heroku-python.json
Outdated
Show resolved
Hide resolved
|
|
|
I think we addressed all comments and the PR checks are looking good. Anything we missed? |
Co-authored-by: Michael Kriese <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This introduces a datasource to handle buildpack registry entries for Cloud Native Buildpacks.
Context
In addition to the existing handling of the
project.toml, the newly added datasource handles entries that are not referring to docker images, but that are https://buildpacks.io/docs/for-app-developers/how-to/build-inputs/specify-buildpacks/ .Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: