Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check for non-labeled issues #32707

Merged
merged 41 commits into from
Dec 17, 2024

Conversation

ph1l1pF
Copy link
Contributor

@ph1l1pF ph1l1pF commented Nov 24, 2024

Changes

This PR will create a new workflow that once in a week will check all open issues and search if any of them are not labeled correctly. If all of them are labeled as expected, it'll cleanly complete the job, otherwise, a new issue reporting the unlabeled issues will be created.

I have tested the action on a test repository: https://github.com/ph1l1pF/renovate-test/issues

Context

Closes #16273

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@ph1l1pF ph1l1pF marked this pull request as draft November 26, 2024 13:55
@ph1l1pF ph1l1pF marked this pull request as ready for review November 26, 2024 17:09
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we determine what the results would be for this repo prior to merging? e.g. via a console output or running the same logic manually locally?

Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review.

I'll review the Bash script soon. 😉

.github/workflows/check-unlabeled-issues.yml Outdated Show resolved Hide resolved
.github/workflows/check-unlabeled-issues.yml Outdated Show resolved Hide resolved
docs/development/issue-labeling.md Outdated Show resolved Hide resolved
tools/check-unlabeled-issues.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second round of reviews, this time for the comments in the script.

After the suggestions and changes have been made, we need to check the technical bits of the Bash script itself.

tools/check-unlabeled-issues.sh Outdated Show resolved Hide resolved
tools/check-unlabeled-issues.sh Outdated Show resolved Hide resolved
tools/check-unlabeled-issues.sh Outdated Show resolved Hide resolved
tools/check-unlabeled-issues.sh Outdated Show resolved Hide resolved
tools/check-unlabeled-issues.sh Outdated Show resolved Hide resolved
tools/check-unlabeled-issues.sh Outdated Show resolved Hide resolved
tools/check-unlabeled-issues.sh Outdated Show resolved Hide resolved
tools/check-unlabeled-issues.sh Outdated Show resolved Hide resolved
tools/check-unlabeled-issues.sh Outdated Show resolved Hide resolved
tools/check-unlabeled-issues.sh Outdated Show resolved Hide resolved
ph1l1pF and others added 16 commits November 27, 2024 21:15
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain what the Label check action label is used for? And in particular: is this solution impossible without it?

@rarkins
Copy link
Collaborator

rarkins commented Dec 5, 2024

Could you explain what the Label check action label is used for? And in particular: is this solution impossible without it?

Could the issue be identified instead using author + issue title?

@ph1l1pF
Copy link
Contributor Author

ph1l1pF commented Dec 5, 2024

Could you explain what the Label check action label is used for? And in particular: is this solution impossible without it?

Could the issue be identified instead using author + issue title?

@rarkins The label is just a way to identify the issue that lists the other issues. Title + author (bot) ist also possible. This would have the benefit that no label has to be created. I can try that.

@ph1l1pF
Copy link
Contributor Author

ph1l1pF commented Dec 13, 2024

Could you explain what the Label check action label is used for? And in particular: is this solution impossible without it?

Could the issue be identified instead using author + issue title?

@rarkins The label is just a way to identify the issue that lists the other issues. Title + author (bot) ist also possible. This would have the benefit that no label has to be created. I can try that.

@rarkins I have done it. This has even simplified the script a little:)

rarkins
rarkins previously approved these changes Dec 14, 2024
@rarkins rarkins requested review from viceice and secustor December 14, 2024 06:41
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small text changes.

tools/find-issues-with-missing-labels.sh Outdated Show resolved Hide resolved
tools/find-issues-with-missing-labels.sh Outdated Show resolved Hide resolved
docs/development/issue-labeling.md Outdated Show resolved Hide resolved
@ph1l1pF ph1l1pF requested a review from HonkingGoose December 16, 2024 14:14
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Else LGTM, but would prefer to keep all tools in the JS/TS ecosystem for maintenance

.github/workflows/find-issues-with-missing-labels.yml Outdated Show resolved Hide resolved
@ph1l1pF ph1l1pF requested a review from secustor December 16, 2024 21:13
@rarkins rarkins added this pull request to the merge queue Dec 17, 2024
Merged via the queue into renovatebot:main with commit e882f1f Dec 17, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.72.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run a GitHub Action weekly to check for issues that are missing labels
5 participants