Skip to content
This repository has been archived by the owner on Jan 4, 2024. It is now read-only.

Minimal Nuxt Bridge migration #157

Closed
wants to merge 23 commits into from
Closed

Minimal Nuxt Bridge migration #157

wants to merge 23 commits into from

Conversation

jtc42
Copy link
Contributor

@jtc42 jtc42 commented Aug 17, 2022

PR to track the initial migration to Nuxt Bridge as per https://v3.nuxtjs.org/getting-started/bridge/

Right now, its a bare minimum migration to help keep it in sync with main while we track outstanding issues preventing us from using Bridge in production.

Conversion as per https://v3.nuxtjs.org/bridge/bridge-composition-api/

Major environment changes

Blockers

es5-ext filesystem error

Builds currently failing with:

 ERROR  [uncaughtException] The argument 'path' must be a string or Uint8Array without null bytes. Received 'ukrdc-nuxt/node_modules/es5-ext/string/\x00#/contains/index.js'

  at readFile (node:fs:393:10)
  at go$readFile (node_modules/graceful-fs/graceful-fs.js:118:14)
  at Object.readFile (node_modules/graceful-fs/graceful-fs.js:115:12)
  at Storage.provide (node_modules/webpack/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:90:3)
  at CachedInputFileSystem.readFile (node_modules/webpack/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:269:25)
  at processResource (node_modules/webpack/node_modules/loader-runner/lib/LoaderRunner.js:202:11)
  at iteratePitchingLoaders (node_modules/webpack/node_modules/loader-runner/lib/LoaderRunner.js:158:10)
  at runLoaders (node_modules/webpack/node_modules/loader-runner/lib/LoaderRunner.js:365:2)

plotly requires es5-ext which seems to be causing issues with webpack due to the unusual null sections of the file paths. See medikoo/es5-ext#106

Sentry module compatibility

Ideally we should wait for nuxt-community/sentry-module#358

To do

  • Fix runtime config loading across all components (https://v3.nuxtjs.org/bridge/overview#new-plugins-format-optional)
  • Fix tailwind issues (e.g. (1:1) autoprefixer: Replace color-adjust to print-color-adjust. The color-adjust shorthand is currently deprecated.)
  • Remove legacy API imports and calls from pages
  • Remove legacy API imports and calls from layouts
  • Remove legacy API imports and calls from helpers
  • Remove legacy API imports and calls from components
  • Port all plugins to new format
  • Remove local store (depends on Add basic user preferences sqlite database ukrdc-fastapi#381)
  • Document new environment variables in README
  • Document changes required to Docker deployments

@jtc42 jtc42 marked this pull request as draft August 18, 2022 10:22
@jtc42 jtc42 closed this Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant