Generated java types general housekeeping #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Java installer would simply overwrite files instead of removing and recreating the shared_types directory. This resulted in old unused shared types that were removed from the rust app library sticking around in the java shared_types files. This can lead to confusion as kotlin will not see references to these unused types as no longer valid.
StuartHarris
approved these changes
Sep 18, 2023
crux_core/src/typegen.rs
Outdated
| let package_path = package_name.replace('.', "/"); | ||
|
|
||
| // remove any existing generated shared types, this ensures that we remove no longer used types | ||
| fs::remove_dir_all(path.as_ref().to_path_buf().join(&package_path)).unwrap_or(()); |
There was a problem hiding this comment.
I think we can remove the to_path_buf() call, as join() is on &path. This will avoid an unneccesary coercion.
There was a problem hiding this comment.
I removed the unnecessary coercion. Thank you for the bringing that to my attention.
The call to to_path_buf was unnecessary as we were working on a path reference, which already implements the join method.
|
As far as I can tell, Swift and Typescript do not need similar treatment. The java installer puts each type in it's own file within the Java shared_types directory. The swift and typescript installers instead collate all the shared types into a single shared types file which is overwritten with each build. |
|
Ahh perfect. Thanks! |
|
@Trapfether nice improvement. I've definitely run into this issue, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the core app with an android target, java files are generated that we reference from kotlin to help facilitate our interaction with the core app. During this process, any types that were no longer being used were left in place. This PR updates the Java type generation helper clean up the shared types directory before generating the updated set of types.