feat: react 19 ftw #7329
Open
feat: react 19 ftw #7329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -60,13 +60,15 @@ export default async function compileMDX( | |||
| .join('\n'); | |||
|
|
|||
| // Turn the MDX we just read into some JS we can execute. | |||
| const {remarkPlugins} = require('../../plugins/markdownToHtml'); | |||
| // const {remarkPlugins} = require('../../plugins/markdownToHtml'); | |||
There was a problem hiding this comment.
check why we aren't able to use remark / rehype plugins after upgrading it.
getting
Error: Expected usable value but received an empty preset, which is probably a mistake: presets typically come with `plugins` and sometimes with `settings`, but this has neither
Comment on lines
+39
to
+45
| // const cached = await store.get(hash); | ||
| // if (cached) { | ||
| // console.log( | ||
| // 'Reading compiled MDX for /' + path + ' from ./node_modules/.cache/' | ||
| // ); | ||
| // return cached; | ||
| // } |
There was a problem hiding this comment.
for now removed caching re enable before we push it to main
| type: type, | ||
| key: key, | ||
| ref: null, | ||
| props: props, | ||
| _owner: null, | ||
| _store: null, |
There was a problem hiding this comment.
Im unsure what this is used for and also should I update react to soft check for _store?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update: works in local properly
build fails due to