Fix:#6336- Adding Early return in set function example

[wAsI7]

No description provided.

[facebook-github-bot]

Hi @wAsI7!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[github-actions]

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[smikitky]

Why add a new useEffect to adjust state? Unfortunately, this is an anti-pattern, and the current docs clearly says you shouldn't rely on useEffect to solve this.

@alesmenzel pointed out in #6336 that the code is slightly inefficient without an early return. However, your "fix" significantly worsens the situation by forcing a commit (DOM update) before a re-render.

For example, when the count changes from 5 to 6, the actual DOM will be updated to <><h1>6</h1><> first. Then useEffect will be triggered, and then useState will be called, and the DOM will be updated again with <><h1>6</h1><p>The count is increasing</p></>. This is far more inefficient than the original.