-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add <form> Component reference documentation #6312
Conversation
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super cool! I appreciate the examples. As this gets closer to shipping we'll want to figure out more user friendly and less code-centric examples of course. I'm sure you have a list of things you want to do and I jumped the gun on reviewing this anyways 😀
FYI:
More details in https://vercel.com/docs/deployments/generated-urls and https://github.com/orgs/vercel/discussions/970#discussioncomment-3918729 for forks. |
Co-authored-by: Luna <[email protected]>
In person code review notes with @lunaleaps :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this! Thanks for all the updates. I have some suggestions -- mostly spelling and occasional sentence re-ordering but those aren't blocking!
I think the only blocking thing is the error boundary example not working
Add initial reference documentation for the
<form>
ComponentPreview