Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add error logging and retry to threadCreate resume #395

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

kristersd
Copy link
Contributor

Add additional error logging for the resume feature and handle retrying the firstMessage when thread has been created

@kristersd kristersd requested a review from vcarl August 6, 2024 10:29
Copy link

what-the-diff bot commented Aug 6, 2024

PR Summary

  • Enhanced Error Handling in Fetching Starter Messages
    The import for the Message class has been added in our major feature file. This ensures that we have the right data type for our messages. Moreover, we now have better error handling for fetching starter messages from both channels and threads. If for some reason these fetch attempts fail, the system will record these instances, helping us troubleshoot future issues.

  • Refactor of 'retry' Function
    The 'retry' function, crucial in resending failed operation requests, has been improved with more flexibility. Instead of requiring separate arguments, it now accepts an options object. This change also extends to its usage in our major feature file making the code tidier and more maintainable.

src/features/resume.ts Outdated Show resolved Hide resolved
src/features/resume.ts Outdated Show resolved Hide resolved
@kristersd kristersd force-pushed the kristersd-resume-improvements branch from c5df400 to d985bc5 Compare August 7, 2024 15:44
@kristersd kristersd merged commit 5ddaebb into main Aug 7, 2024
3 checks passed
@kristersd kristersd deleted the kristersd-resume-improvements branch August 7, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants