Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto thread title fix, Resume Review features #375

Merged
merged 9 commits into from
Jun 6, 2024
Merged

Auto thread title fix, Resume Review features #375

merged 9 commits into from
Jun 6, 2024

Conversation

vcarl
Copy link
Member

@vcarl vcarl commented Jun 4, 2024

Copy link

what-the-diff bot commented Jun 4, 2024

PR Summary

  • Enhanced Project Documentation
    A link to the CONTRIBUTING.md file was added for convenient access to contribution guidelines.

  • Refactored Key Features
    Several features namely autoban, autothread, promotionThread, resumeReviewPdf, troll, and tsPlaygroundLinkShortener were updated to use msg parameter instead of maybeMessage resulting in smoother functioning.

  • Updated resume-review.ts File
    Newly added imports and functions enhance the overall system functionality.

  • Improved Command Handling in resume.ts File
    The resume.ts file is now updated with a new command (resumeResources) that expands its interaction ability with buttons. It no longer features the reviewResume command in the resumeResources function, simplifying operation.

  • Cleaned Up Command Registration
    The index.ts file was updated to remove the reviewResume command from registerCommand, resulting in a more streamlined command registration process.

  • Simplified Interface in types/index.ts File
    The PartialMessage type was removed from the HandleMessageArgs interface in the types/index.ts file, simplifying the interface structure.

vcarl added 5 commits June 4, 2024 15:19
We were already always fetching the message before calling handlers, which makes these checks redundant. Let's just get rid of them all
@vcarl vcarl changed the title Add x.com to twitter embed title logic Auto thread title fix, Resume Review features Jun 4, 2024
@vcarl vcarl marked this pull request as ready for review June 4, 2024 20:53
@vcarl
Copy link
Member Author

vcarl commented Jun 4, 2024

Resume Review AI demo:

Screen.Recording.2024-06-04.at.4.52.26.PM.mp4

src/index.ts Outdated Show resolved Hide resolved
Grouping them like this meant posters couldn't reply with their resume if nudged for it, they would have had to make a new post. Not desireable
src/features/resume-review.ts Outdated Show resolved Hide resolved
src/features/resume-review.ts Outdated Show resolved Hide resolved
Co-authored-by: Kristers Duģels <[email protected]>
src/features/resume-review.ts Outdated Show resolved Hide resolved
@vcarl vcarl merged commit 47770f1 into main Jun 6, 2024
3 checks passed
@vcarl vcarl deleted the vc-bugfixes branch June 6, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thread creation fails to pull Twitter info AI resume review revisions
2 participants