Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify formatting for voice channel logs #345

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Simplify formatting for voice channel logs #345

merged 2 commits into from
Dec 14, 2023

Conversation

vcarl
Copy link
Member

@vcarl vcarl commented Dec 14, 2023

Screenshot 2023-12-14 at 2 19 48 AM

Copy link

what-the-diff bot commented Dec 14, 2023

PR Summary

  • Introduction of Schedule Task Function
    The code update in src/features/voice-activity.ts imports a new function scheduleTask which is utilized for task scheduling.

  • Parameters Update in Voice Activity Function
    The function voiceActivity within our voice-activity.ts module now requires an extra parameter, bot. This allows the function to increase its efficiency by scheduling tasks and handling voiceStateUpdate events directly.

  • Movement of Voice State Update Event Handling
    The management of voiceStateUpdate events is now taken care of directly within the voiceActivity function in src/features/voice-activity.ts. This function now also keeps a log when someone joins or leaves a voice channel, which will benefit us by increasing the system's visibility on user voice channel activities.

  • Import of Voice Activity Module
    VoiceActivity module is being imported into our main application file (src/index.ts). The significance of this is that it allows us to adopt the new functionalities within our main application.

  • Deployment of Voice Activity Function
    The voiceActivity function is executed within the src/index.ts file with the bot as its input parameter. This means our 'bot' is now utilizing the enhanced functionalities that the voiceActivity function offers.

  • Removal of Handle Voice State Update Function
    Finally, synchronizing with the move of voiceStateUpdate event handling, the older handleVoiceStateUpdate function was eliminated from src/index.ts. This move simplifies our code and reduces potential redundancy.

@ghost
Copy link

ghost commented Dec 14, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@vcarl vcarl merged commit f3bcf02 into main Dec 14, 2023
3 checks passed
@vcarl vcarl deleted the vc-log-format branch December 14, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant