Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voice activity tracking #341

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Add voice activity tracking #341

merged 4 commits into from
Dec 11, 2023

Conversation

dylangarcia
Copy link
Contributor

Does what it says on the box. It needs a new intent but afaict the bot itself doesn't need to be updated for that? Idk how intents work.

image

Copy link

what-the-diff bot commented Dec 11, 2023

PR Summary

  • Introduction of Voice Activity Module
    A new file called voice-activity.ts has been added. This serves as a dedicated space for managing voice activities within Discord channels (like who is speaking or not).

  • Inclusion of New Module to Channel Handlers
    The new voiceActivity module is now incorporated into our channel handlers, courtesy of modifications made in the index.ts file. With this change, the functionality of voice activity handling can be conveniently managed and accessed from the existing list of channel handlers.

  • Addition of Listener for Voice State Updates
    With changes made to index.ts, we now have a new event listener for any updates in voice state, such as someone joining or leaving a voice channel. When these events occur, our system swiftly responds and executes the handleVoiceStateUpdate function to ensure proper adjustments are made accordingly.

  • Introduction of New Type for Voice State Changes
    A new type HandleVoiceStateChangeArgs is now available in types/index.ts. This brings more clarity and type safety while working with voice state change events, making carrying out associated operations more reliable.

@ghost
Copy link

ghost commented Dec 11, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@vcarl
Copy link
Member

vcarl commented Dec 11, 2023

Nice, tested locally and it looks good

@vcarl vcarl merged commit 59ad216 into main Dec 11, 2023
3 checks passed
@vcarl vcarl deleted the feature/voice-activity-tracking branch December 11, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants