Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secret creation #334

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix secret creation #334

merged 1 commit into from
Nov 21, 2023

Conversation

vcarl
Copy link
Member

@vcarl vcarl commented Nov 21, 2023

No description provided.

Copy link

what-the-diff bot commented Nov 21, 2023

PR Summary

  • Explanation Added in Workflow File
    Comments have been introduced in the workflow file, which provide information about the purpose of the subsequent steps. This will help in better understanding of the function of each step.

  • Environment Variables Addition in Deployment Command
    Two new environment variables, AMPLITUDE_KEY and OPENAI_KEY, have been included in the "Deploy app" step command. These additional variables would influence the behavior of the app after deployment.

  • Removal of Echo Expression
    The appendage || echo \n at the end of each option in the "Deploy app" step has been done away with. This change leads to cleaner syntax and avoids potential confusion.

  • Change in Kubectl Command
    There has been a change in the kubectl command, where kubectl apply -k . is now replaced by kubectl apply -k .. However, it appears this change repeats the same command, and it's perhaps a mistake that will need to be addressed.

@ghost
Copy link

ghost commented Nov 21, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@vcarl vcarl merged commit 120169b into main Nov 21, 2023
3 checks passed
@vcarl vcarl deleted the vc-fix-deploy branch November 21, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant