Hotfix: Kysely doesn’t parse JSON values from sqslite (#71)

reactiflux · Sep 6, 2024 · 236df07 · 236df07
1 parent 2c86275
commit 236df07
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/app/db.server.ts b/app/db.server.ts
@@ -1,5 +1,5 @@
 import SQLite from "better-sqlite3";
-import { Kysely, SqliteDialect } from "kysely";
+import { Kysely, ParseJSONResultsPlugin, SqliteDialect } from "kysely";
 import type { DB } from "./db";
 import { databaseUrl } from "./helpers/env";
 
@@ -13,6 +13,7 @@ export const dialect = new SqliteDialect({
 
 const db = new Kysely<DB>({
   dialect,
+  plugins: [new ParseJSONResultsPlugin()],
 });
 
 export default db;

diff --git a/app/models/guilds.server.ts b/app/models/guilds.server.ts
@@ -60,7 +60,7 @@ export const fetchSettings = async <T extends keyof typeof SETTINGS>(
   guild: DiscordGuild,
   keys: T[],
 ) => {
-  return (
+  const result = Object.entries(
     (await db
       .selectFrom("guilds")
       // @ts-expect-error This is broken because of a migration from knex and
@@ -71,6 +71,9 @@ export const fetchSettings = async <T extends keyof typeof SETTINGS>(
       )
       .where("id", "=", guild.id)
       // This cast is also evidence of the pattern being broken
-      .executeTakeFirstOrThrow()) as Pick<SettingsRecord, T>
+      .executeTakeFirstOrThrow()) as Pick<SettingsRecord, T>,
+  );
+  return Object.fromEntries(
+    result.map(([k, v]) => [k, JSON.parse(v as string)]),
   );
 };