Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [useKeyboard] Reduce re-renders amount #409

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

retyui
Copy link
Contributor

@retyui retyui commented Nov 26, 2024

Summary

I see that my component is re-render 3 times on keyboardDidShow event as useKeyboard has 3 setState invokes
Using a single state should solve this problem on all old and modern ver. or react

Test Plan

...

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android
Web

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I've created a snack to demonstrate the changes: LINK HERE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant