-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include undo and apply functional options pattern for setting logger #8
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
|
Hi @rdforte , I just used this implementation + an adaptation to my proposition change in the Log output:
|
Description
This change is in accordance with Proposal 2 for open-telemetry/opentelemetry-collector-contrib#36814
This change extends the Set method by:
Adds a new method
IsECS
to check if current process running in ECS.NOTES
For anyone using Set this does break their current usage of
Set
. So we can either add this change as a new method and bump the minor version or update the existingSet
method and bump the major version.