-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RayCluster] Adds aliyun.com/gpu-mem
to known custom accelerators
#2631
base: master
Are you sure you want to change the base?
Conversation
bde319f
to
9fe74f0
Compare
@@ -38,11 +38,14 @@ const ( | |||
NeuronCoreRayResourceName = "neuron_cores" | |||
TPUContainerResourceName = "google.com/tpu" | |||
TPURayResourceName = "TPU" | |||
GPUShareContainerResourceName = "aliyun.com/gpu-mem" | |||
GPUShareResourceName = "gpu_share" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the actual resource name recognized by Ray? aliyun.com/gpu-mem
-> gpu_share
seems like an odd mapping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, I realized that Ray Resource Name only supports GPU, neuron_cores, TPU, NPU, and HPU. I will mapping aliyun's gpu share to GPU.
Ref: https://docs.ray.io/en/latest/ray-core/scheduling/accelerators.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I think we should only add custom accelerators here that are in the supported list you referenced
aliyun's gpu share
to known custom accelerators
Signed-off-by: win5923 <[email protected]>
aliyun's gpu share
to known custom acceleratorsaliyun.com/gpu-mem
to known custom accelerators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref: #2631 (comment)
I mapped |
Can you first open a PR to update the officially supported accelerators in https://docs.ray.io/en/latest/ray-core/scheduling/accelerators.html to include alyun.com/gpu? |
I checked Aliyun's documentation, and I think they also use Nvidia GPU with field called
So I think we should just focus on the string? |
Why are these changes needed?
if use aliyun k8s gpu share, gpu key is
aliyun.com/gpu-mem
autoscaler will not work when request gpu resource
Adds aliyun's gpu share to the list of known custom accelerators in
pod.go
Related issue number
Closes #2484
Checks