Use codecov from CI images
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes `codecov` implementation to use binary instead of GH Action wrapper. The GH Action wrapper seemed to intermittently fail. Hopefully using the binary directly fixes that
bdice
approved these changes
Nov 30, 2022
| directory: ${{ env.RAPIDS_COVERAGE_DIR }} | ||
| verbose: true | ||
| - name: Run codecov | ||
| if: inputs.run_codecov && contains(fromJson('["X64", "X86"]'), runner.arch) |
There was a problem hiding this comment.
We probably only need one value here, right? Which is it?
There was a problem hiding this comment.
Probably only X64. I got the full list of values at the link below. I'll update it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
codecovimplementation to use the binary included in our CI imagescodecov/codecov-action@v3codecovonly runs onx86/x86_64machinesarm, see this issuebuild_type == 'pull-request'restriction from thecodecovstepcodecovresults forbasebranches (see here for why that's important)RAPIDS_TESTS_DIRenvironment variable whose value is a directory path where unit test results can be saved toRAPIDS_COVERAGE_DIRenvironment variable from Add custom-job.yaml, RAPIDS_BASE_BRANCH, Codecov support #20tests_result_dirinput